mcop1

Results 70 comments of mcop1

So, pr looks good to me, but on second thought, changing the setters in `ElementInterface` and `AbstractElement` is a breaking change, probably in `CustomLayout` too. Guess we need to postpone...

Hello, thank you for creating the ticket. To be honest, if the modificationDate was updateable before, then, in my opinion, that was a bug. After internally discussions, we decided that...

Hello @gutentag2012 , I couldn´t reproduce the problem. Could you please elaborate a bit? Which pimcore and data-hub version are using? How does your query look like exactly. I tried...

Hello @vmalyk , thank you so much for all the changes. Unfortunately, merging the other prs resulted in a merge conflict in this pr. Could you please have a quick...

Hello @vmalyk , never mind, I was able to resolve the conflict. Failing test is about the missing secret, it should be fine after merging it back into the base...

Hello @vmalyk agreed, we can keep it consistent. I created a ticket to take a look at the classes and make them final/internal (if it is fitting) for the next...

Hello @AlternateIf , thanks for the pr. What do you think about using `quote` method of db class? And maybe `quoteDataIdentifiers` method of Helper class (https://github.com/pimcore/pimcore/blob/22b2ae4f38f759cd2f0612bdaf051124a233ebb9/lib/Db/Helper.php#L113) instead of the tmp...

@AlternateIf did you have any chance to have a look at this again? To rebase it and maybe provide an example to reproduce the issue? Thank you for your efforts!