libmsym icon indicating copy to clipboard operation
libmsym copied to clipboard

Published 20 hours ago • verified publisher icon mcodev31

fix: fix `-Wvla-parameter`

Open e-kwsm opened this issue 2 years ago • 2 comments

e-kwsm avatar Nov 10 '23 16:11 e-kwsm

Hi Eisuke,

It will take me some time to go though all your requests (they generally look good, I just rarely have the time), but this caught my eye since I know a few projects that use c++ compilers w/o vla support, and this looks to me like it would not compile? I'm not currently on a computer where I can check, but the header files need to be c++ compatible.

mcodev31 avatar Nov 20 '23 20:11 mcodev31

Thank you for your review. I tried a small snippet and found that g++ 12.2.0 does not support VLA for parameter.

e-kwsm avatar Nov 21 '23 07:11 e-kwsm