instagram-node-lib icon indicating copy to clipboard operation
instagram-node-lib copied to clipboard

try catch around complete causing confusing errors

Open kumikoda opened this issue 12 years ago • 1 comments

i originally posted this as an issue i thought your library had. But i quickly realized that this was an error in my own code.

The confusion stems from the try/catch in class.instagram.coffee at line 129. I think your try catch is intended for the JSON.parse() line but it covers the complete statement as well, causing it to catch any uncaught errors in the callback. Instead, would it better just to throw the otherwise uncaught exception?

kumikoda avatar May 20 '13 23:05 kumikoda

agree , I fall in the same trap

gabrielstuff avatar Dec 12 '13 20:12 gabrielstuff