Refactor LevelObject Into Multiple Classes

[TheJoeSmo]

Is your feature request related to a problem? Please describe. At the current state LevelObject located in game/gfx/objects is very hard to understand, let alone change. The class itself takes over 900 lines of code and is required to edit for any future generators.

Describe the solution you'd like I believe we need refactor LevelObject into multiple smaller classes. We will need an adapter to act like ObjectLike instead of forcing the entire class to act like it. This is for many reasons: it is hard to test, it makes LevelObject brittle, and it forces LevelObject to take on too much responsibility.

Once LevelObject is not bound to ObjectLike, we can begin to use many tactics to divide this class into different jobs. My proposal is we make LevelObject only responsible for the in game memory representation of the generator. We decorate LevelObject with a LevelObjectRenderer to implement the draw, render and as_image methods. Finally, LevelObjectRenderer will utilize the adapter in order to act like ObjectLike.

Methods I deem not critical for LevelObject that should be reimplemented elsewhere:

• draw
• _draw_block
• set_position
• move_by
• get_position
• expands
• primary_expansion
• resize_x
• resize_y
• resize_by
• increment_type
• decrement_type
• change_type
• point_in
• get_status_info
• display_size
• as_image
• render
• _render

Personally, I don't believe all these methods should be removed, but instead refactored into a property that can be set similarly. The main properties that come to mind are position and size and possibly primary_expansion.

Describe alternatives you've considered There are alternatives to the solution provided, but ultimately any good solution will require an adapter for ObjectLike as it has so much responsibility. Where to put specific methods is can be debated.