saml-idp icon indicating copy to clipboard operation
saml-idp copied to clipboard

Add travis-ci docker image pipeline

Open ghost opened this issue 6 years ago • 3 comments

Resolves https://github.com/mcguinness/saml-idp/issues/53

Unable to fully test this as TravisCI does not run on forks, and Docker Hub credentials need to be setup.

ghost avatar Jul 30 '19 00:07 ghost

@JaneJeon I can look into some options but it does look like there have been several updates this year to the repo by @mcguinness and others. I would prefer to have the image be based upon the latest source if possible and updated automatically via CI/CD (Maybe GitHub Actions now instead of Travis CI).

If you need an image before then I would recommend building and pushing up your own. This has the added benefit of using a stable commit you know works for you.

https://github.com/mcguinness/saml-idp#docker

# assuming you are in root of repo
docker build . -t janejeon/saml-idp:latest
docker push janejeon/saml-idp:latest

ghost avatar Jul 20 '20 20:07 ghost

I am maintaining the code. Is the ask here just to publish an image to docker hub on each release? What else is needed besides a .travis.yml file for CI/CD workflows? I am assuming the Dockerfile in the repo is fine, does that need any changes?

mcguinness avatar Jul 20 '20 21:07 mcguinness

@mcguinness I think everything Docker related is already good to go, just the CI/CD workflow to publish an image on each release.

ghost avatar Jul 20 '20 21:07 ghost