arduino-lmic
arduino-lmic copied to clipboard
Add SX1276 version 0x13 for S76G
The SX1276 in my LilyGO T-Motion seems to be version 0x13 and this seems to be the case for all S76G packaged chips. Currently the library checks for version 0x12, and fails.
This also seems to be LilyGO's advice for the T-Impulse: https://github.com/Xinyuan-LilyGO/T-Impulse#notice
I'm not sure if there are any differences other than being packaged in an S76G, but it works fine for me!
Thanks, Steve
Just realised, this is a duplicate of #790. Although this is slightly better in that it uses logical and (&&), instead of bitwise and (&), so I guess I'll leave it open.
Yes, thanks for doing the review. I agree using && is preferred; I was going to look at that once I got "official" confirmation from Semtech on device IDs. I'm a little reluctant to make changes that are not in the official data sheet, but the LilyGo advice is at least more official than "we checked this and it seems to be right". I have a backlog of things to look at but will try to merge this soon.