mobile-angular-ui icon indicating copy to clipboard operation
mobile-angular-ui copied to clipboard

Fixing file location on package.json

Open santiagovazquez opened this issue 8 years ago • 2 comments
trafficstars

santiagovazquez avatar Feb 18 '17 00:02 santiagovazquez

Codecov Report

Merging #413 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #413   +/-   ##
=======================================
  Coverage   82.56%   82.56%           
=======================================
  Files          14       14           
  Lines         562      562           
=======================================
  Hits          464      464           
  Misses         98       98

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5ec10ac...002ed97. Read the comment docs.

codecov-io avatar Feb 18 '17 00:02 codecov-io

I think re-building the dist/ folder as part of the commit is a bad idea because the contents of your dist may not necessarily reflect all the commits that have gone into master since your generated dist was created. It also pollutes the diff when trying to do code reviews or check commits in the git history.

jaythomas avatar Jul 19 '17 19:07 jaythomas