rust-herbie-lint icon indicating copy to clipboard operation
rust-herbie-lint copied to clipboard

Run it on “a ton of crates in the ecosystem”

Open mcarton opened this issue 9 years ago • 2 comments

In order to test the plugin, feed a Rust-specific database and improve other crates, the plugin should be tried on lots of crates in the ecosystem.

Some ideas of crates with potentially lots of floating point expression (from a quick search of "math" on crates.io, so many crates are missing, and all of the following might not be relevant):

  • [ ] ncollide
  • [ ] nphysics
  • [x] cgmath
  • [x] closed01
  • [x] dumbmath
  • [x] fast-math
  • [x] fiz-math
  • [x] glm
  • [x] image
  • [x] imageproc
  • [x] nalgebra
  • [x] noise
  • [x] vecmath

Don't hesitate to suggest more if you know some crates that should be on the list :smile:

mcarton avatar Jan 11 '16 20:01 mcarton

Maybe you could also try these:

  • nalgebra
  • ncollide
  • nphysics
  • vecmath
  • image
  • imageproc

(I'm not sure if they are all relevant. But I thought they may contain lots of floating point expressions)

tillarnold avatar Jan 26 '16 15:01 tillarnold

@tillarnold thanks, none of them have reported anything, some are using f32, which is not considered by the plugin yet (but it definitely should be as Herbie does support single precision floating points) and some hide math behind generics, which I’m not sure I could lint reliably. And of course maybe none of them have anything wrong to lint about :smile:.

mcarton avatar Jan 26 '16 16:01 mcarton