qlcplus
qlcplus copied to clipboard
Add Kiosk Toggle Button
Added an option to the Virtual Console Button allowing the user to enable and disable kiosk mode from the Virtual Console. A four to six digit PIN is set within the button properties to prevent unauthorized use.
coverage: 33.899% (-0.04%) from 33.943% when pulling 9955a4b3fa110926ebf178ecda9b9b9d2af7bdf2 on crackley:master into ef1c9ce89bbde274edeb73c42bfc91e0e2a5e8d1 on mcallegari:master.
I like your idea. @mcallegari can you please approve the workflow so I can test?
There's a few things you can do to help this get upstream:
- A forum thread should be created and linked so active users can discuss the change
- Make sure the PR conforms to the coding style
- Can you also please create a PR for our documentation repo here. You should probably add it to the Virtual Console page.
We now have a PR template you can use to help us merge stuff faster.
Thanks! I will work on those items as soon as I can. For the PR template, do I copy and paste that here and edit as necessary?
Thanks! I will work on those items as soon as I can. For the PR template, do I copy and paste that here and edit as necessary?
I followed the instructions which should have self-inserted it when you create the PR. I guess I've done something wrong.
Just copy it into the main PR comment and fill as necessary. I have a build I can test tonight :)
Decided to to close this request until I have time to integrate it with the existing kiosk feature instead of making it a standalone feature. It has worked great for me but realized the feature duplication could be confusing for end users.