Function Wizard: create Effects

[8-Lambda-8]

trafficstars

Hi, I added the possibility to create Effects with the Function Wizard What types of effects arc creates is determined by the fixture capabilities (Dimmer, RGB, Position). for each type a normal and a staggered version (start offset spread equally) will be created.

[mcallegari]

Hi, this doesn't build. Can you please fix it?

[coveralls]

coverage: 31.812% (-0.06%) from 31.872% when pulling 22b91406da3087baa67172a48fcd5ee424eb53a5 on 8-Lambda-8:effectsInWizard into 7fd06c76dd66b677673c1c1bec0b39e1cba6457f on mcallegari:master.

[8-Lambda-8]

i fixed it

i did not see that EFXFixture has a modeToString function

i removed the line and used this function instead

[yestalgia]

Hey guys I've had a think about this.

Eventually I'd like to expand the EFX movement effect list. I think these should be separated in the wizard.

My suggestion would be:

• Primary Colors
• 16 Colors
• Animations
• EFX
  • Position
    • Line
    • Circle
    • etc.
  • RGB

Is there a better way for us to feed settings into the position effects like "Staggered", Split Reverse", "Asymmetrical" etc.?

[8-Lambda-8]

Hi, Yes, i will add the Modes (Pos, RGB, int) as sub items in the tree, but im not sure about the patterns. I think the list will get too long. And in my opinion you rarely want to create all of them, so you have to select/deselect to get your liked outcome. For me it would be enough to just create one and then manually duplicate and change the pattern. I see the real timesaver of this feature in generating the mode/offset/reverse settings.

For the offset/reverse settings, i could add columns with checkboxes (like odd/even)(i also have to implement odd/even) What exactly do you mean with "Split Reverse" and "Asymetrical"? so i can add them as options

[8-Lambda-8]

Hi, i added the mode sub items and the checkbox columns (not implemented the generation yet)

now it looks like this, what do you think?

[yestalgia]

Mate we should be calling you the wizard! This is fantastic stuff!

What exactly do you mean with "Split Reverse" and "Asymetrical"? so i can add them as options

I'm referring to the fixture order setting in the EFX:

No stress if this is too complex.

im not sure about the patterns. I think the list will get too long.

Personally, I would find the patterns extremely helpful, but I understand the concern. Perhaps this would need to form part of a separate step.

[8-Lambda-8]

I'm referring to the fixture order setting in the EFX:

oh, i totally forgot that those exist, shouldn't be a problem to implement this. and i realized that my "staggered" does the same as "Serial", so i will remove it.

also i noticed the "Serial" and "Asymmetric" are not displayed in the movement preview (all points are on the same spot), i will try to fix this and create a separate PR for that.

Personally, I would find the patterns extremely helpful, but I understand the concern. Perhaps this would need to form part of a separate step.

okay, i'll try to do that

[finnie2006]

What is the status on this pr?

[8-Lambda-8]

Hi, i still have to think about how i can add a selection of the patterns and fix some stuff on the VC Widget creation page and fix the tests :)

[8-Lambda-8]

Hi, i now have added the patterns like @yestalgia suggested. They are collapsed by default, so that the list is not too long. It is not that bad as i first thought it would be :)

[yestalgia]

Well.... That's incredible work! I'll be doing some testing especially with multi-head fixtures next week.

[finnie2006]

I also builded your fork, going to test it with my movingheads

[mcallegari]

Please rebase with master and fix the code style to conform with the rest of the project (one above all: parenthesis on new line) Thanks

[8-Lambda-8]

i think the parts of the code that i touched conform with the code style. Did i miss anything?