qlcplus icon indicating copy to clipboard operation
qlcplus copied to clipboard

Fix bugs in Fixture Search

Open lilyCalla opened this issue 1 year ago • 4 comments
trafficstars

Bugs fixed:

  • selecting or deselecting a fixture with Fixture Groups panel open results in a segfault
  • Escape erases the names of fixtures and universes
  • Switching from Fixture Groups view to another view in the left panel and then switching back to fixture view does not clear filter until the search button is clicked again, without any visual indication that a filter is still active

lilyCalla avatar May 01 '24 15:05 lilyCalla

Coverage Status

coverage: 32.068%. remained the same when pulling 6bf200f03c60652367971be5fb7fe9c63a7669af on lilyCalla:fixture-select-segfault into 3150b445eae811cd84ca76462ba33c98f1f6c074 on mcallegari:master.

coveralls avatar May 01 '24 16:05 coveralls

All stylistic issues resolved

lilyCalla avatar May 02 '24 19:05 lilyCalla

I cannot reproduce the crash mentioned in the OP. Can you please explain exactly how to reproduce it?

mcallegari avatar May 05 '24 08:05 mcallegari

Ok sorry, forgot an important part of the crash.

Search for with a string that the filter you're about to click on does not match (such that it won't appear in the fixture group view). Then select it in the 2d view, and the application crashes

lilyCalla avatar May 05 '24 22:05 lilyCalla

Thanks :+1:

mcallegari avatar May 14 '24 17:05 mcallegari