qlcplus icon indicating copy to clipboard operation
qlcplus copied to clipboard

Published 20 hours ago • verified publisher icon mcallegari

Added web interface for cue list notes live editing.

Open Binary-Vanguard-12138 opened this issue 1 year ago • 3 comments
trafficstars

Hi, @mcallegari I added this PR for web interface of cut list notes live editing. Please review it and give me feedback.

Binary-Vanguard-12138 avatar Feb 04 '24 14:02 Binary-Vanguard-12138

Coverage Status

coverage: 31.994% (+0.04%) from 31.958% when pulling 08e4a693e99b731f189a246d8326179f67eb22c4 on Binary-Vanguard-12138:cuelist_note_live_edit into 09bd20f746c9f23865e51cc1f1ee48f1b6b5ea42 on mcallegari:master.

coveralls avatar Feb 04 '24 17:02 coveralls

I just checked this one. Notes editing is OK but selecting a step from web and hitting play starts from the first element instead of from the selected one. In the native interface this is working as expected. Not sure if this is because of the change discussed above or if it ever was like this but it needs to be fixed. Can you please check?

mcallegari avatar Feb 17 '24 10:02 mcallegari

@mcallegari Hi, I reverted setCueIndex to enableCue. Please review it again.

Binary-Vanguard-12138 avatar Feb 18 '24 08:02 Binary-Vanguard-12138

Merged, thanks. Cue selection is still not OK but I'll fix it myself

mcallegari avatar Feb 23 '24 12:02 mcallegari