vue-burger-menu icon indicating copy to clipboard operation
vue-burger-menu copied to clipboard

Push right not working

Open ghost opened this issue 6 years ago • 6 comments
trafficstars

Hello,

Thank you for the great package! With the last NPM version (2.0.1) the push right doesn't work.

Code:

<main id="page-wrap">
...
</main>

<Push right>
   <a id="home" href="#">
      <span>Home</span>
   </a>
</Push>
  • Hamburger is now on the right (good!)
  • page-wrap transform is translate3d(300px, 0px, 0px); must be translate3d(-300px, 0px, 0px); (wrong)

The default push (@ left side) is correct.

ghost avatar Mar 07 '19 13:03 ghost

Could you please reproduce on CodeSandbox - https://codesandbox.io/s/vue?from-embed

It seems to be working in demo - https://vue-burger-menu.netlify.com/

mbj36 avatar Mar 07 '19 14:03 mbj36

Okay i was able to reproduce. Would you like to open a PR, I would be happy to accept ?

mbj36 avatar Mar 07 '19 14:03 mbj36

@mbj36 thanks for your reply! Nice tool! See https://codesandbox.io/s/41y1yo5w0?fontsize=14

Thanks :)

ghost avatar Mar 07 '19 14:03 ghost

@Royve90 You want to open a PR for the fix ?

mbj36 avatar Mar 07 '19 14:03 mbj36

@mbj36 I do not know how to fix it.

It seems like this if triggers always the else but why?

Edit:

<Push :right=true> 

triggered the if and is working fine.

ghost avatar Mar 07 '19 14:03 ghost

I was having the same issue and also had to use :right="true" in the component. It's a bit misleading in the docs since they say to just use right for the boolean. Maybe the docs should be updated to cause less confusion?

Jack-Barry avatar Jul 29 '20 15:07 Jack-Barry