mo4-coding-standard icon indicating copy to clipboard operation
mo4-coding-standard copied to clipboard

Add PHP 8.5

Open xalopp opened this issue 2 months ago • 5 comments

Type of PR

  • [ ] Bugfix
  • [ ] New Feature
  • [X] Other (explain): Support new PHP version 8.5

Breaking changes

  • [ ] Yes, this is a breaking change

Description

Be prepared for upcoming PHP 8.5 release

xalopp avatar Sep 19 '25 08:09 xalopp

vimeo/psalm currently requires "php": "~8.1.31 || ~8.2.27 || ~8.3.16 || ~8.4.3"

Possible actions:

  • wait for https://github.com/vimeo/psalm/pull/11541 to be merged
  • modify out build workflow to work around vimeo/psalm depedency

xalopp avatar Sep 19 '25 08:09 xalopp

phan also needs an update to PHP 8.5: https://github.com/phan/phan/pull/5066

xalopp avatar Sep 19 '25 09:09 xalopp

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 100.00%. Comparing base (93dad05) to head (cb779e0).

Additional details and impacted files
@@             Coverage Diff             @@
##              master      #226   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity       147       147           
===========================================
  Files              8         8           
  Lines            669       669           
===========================================
  Hits             669       669           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 19 '25 09:09 codecov[bot]

Let's wait for an official 8.5.0 (or .1) release, I'm quite sure all the dependencies will get appropriate updates until then.

mmoll avatar Sep 23 '25 17:09 mmoll