Max Jones

Results 225 comments of Max Jones

@billsacks thanks for implementing a fix for this issue! Is there an estimated timeline for the ESMF 8.7 release?

> FYI they don't really add state in a reliable way anyway, see https://github.com/pydata/xarray/issues/3268. Accessors really should only be thought of as a way to register a method on an...

I really appreciate the discussion here and acknowledge that there'll always be differing opinions on these design patterns. I'm going to close the issue though because we've seemed to progress...

> Q: > > * should we validate the entire dataset > * should we validate all the `variables` > > My knowledge of Xarray dataset structure is limited so...

This approach seems good for short-term use, though eventually it would be nice to use a schema validation approach (e.g., https://github.com/xarray-contrib/xarray-schema) rather than eagerly applying the operations to save time...