Max Nowack

Results 64 comments of Max Nowack

@signalize thanks for the hint! I addressed this issue in #1717 🙂

@signalize I saw you made some changes, but then marked the PR as a draft again. So I haven't reviewed it yet. Was this a mistake and you're waiting for...

Hi @vaggelis-diatsigkos! The `createIndexedDBAdapter` function already takes a name from that the database name [is being generated](https://github.com/maxnowack/signaldb/blob/main/packages/persistence-adapters/indexeddb/src/index.ts#L15). Do you want to get rid of the `signaldb-` prefix or do you...

Ah, I see. Feel free to open a PR to modify it to fit your needs 🙂 > Anyway, I really enjoy signaldb! Thanks, I really appreciate that!

Hi @signalize, I just reviewed your PR again and noticed that you changed the primary key generator to a `beforeInsert` hook. While I appreciate the idea of introducing hooks, I...

Tests are passing and the coverage is at 100% again. I've published beta versions (`2.0.0-beta.0`) for `@signaldb/core`, `@signaldb/sync`, `@signaldb/fs`, `@signaldb/opfs`, `@signaldb/localstorage` and `@signaldb/indexeddb` to npm. Feel free to test and...

I think this message is triggered by the [`createFilesystemAdapter`](https://github.com/maxnowack/signaldb/blob/main/packages/signaldb/src/persistence/createFilesystemAdapter.ts#L18). It shouldn't be a real issue. It should go away when the persistence adapters are splitted in separate packages in v1