MaxMind-DB-Reader-python icon indicating copy to clipboard operation
MaxMind-DB-Reader-python copied to clipboard

Add support for Multi-phase extension module initialization PEP489

Open rcmcdonald91 opened this issue 2 years ago • 3 comments
trafficstars

  • Adds support for PEP489.
  • Indirectly addresses a missing Py_INCREF that can cause segfaults when used by embedded interpreters.

rcmcdonald91 avatar Jan 09 '23 19:01 rcmcdonald91

My first attempt at python extension work, I am addressing failing tests.

In the interim, I have created another PR #106 that directly addresses the missing Py_INCREF issue. #105 needs more work.

rcmcdonald91 avatar Jan 09 '23 19:01 rcmcdonald91

This likely requires a broader discussion on the minimum python version we want to support.

rcmcdonald91 avatar Jan 09 '23 20:01 rcmcdonald91

We generally support all Python versions that are still getting security updates upstream. That would mean that we will want to support 3.7 until June.

I haven't looked too closely at the code yet, but it would be fine to conditionally compile blocks of code for particular Python versions.

oschwald avatar Jan 09 '23 20:01 oschwald