MaxMind-DB-Reader-python
MaxMind-DB-Reader-python copied to clipboard
Add support for Multi-phase extension module initialization PEP489
trafficstars
- Adds support for PEP489.
- Indirectly addresses a missing
Py_INCREFthat can cause segfaults when used by embedded interpreters.
My first attempt at python extension work, I am addressing failing tests.
In the interim, I have created another PR #106 that directly addresses the missing Py_INCREF issue. #105 needs more work.
This likely requires a broader discussion on the minimum python version we want to support.
We generally support all Python versions that are still getting security updates upstream. That would mean that we will want to support 3.7 until June.
I haven't looked too closely at the code yet, but it would be fine to conditionally compile blocks of code for particular Python versions.