Max Korp comments

Results 37 comments of


                                            Max Korp

Loop inside "credentials" callback when using `sshKeyFromAgent`

@cbargren knows how to handle this, if you guys still need help. Edit: @Mr-Wallet should know his way around this somewhat as well.

Remove `git_commit_tree` which duplicates `commit.getTree()`

> The tree(tree_out) function needs a pointer and this does not make any sense in the JavaScript world Shouldnt that pointer be a nodegit commit object which then gets unwrapped?

Set parameter 'ancestor_tree' as optional in 'Merge.trees' method.

Restarted the necessary tests 👍

Tests for repositories that does not exist

Bump. @webjay you still around? @johnhaley81 Per #1072 I doubt this greenlights properly, but it provides a test case for fixing that.

Make nodegit context-aware for compatibility with Electron 9 and beyond

Is there a preference for context-awareness over n-api compat?

Make nodegit context-aware for compatibility with Electron 9 and beyond

After doing some reading up, I think that's a fair evaluation and a good direction to head

Use ESLint with a config base of eslint-airbnb-config-base

At this point, the actual file changes probably need to be reworked. FYI passing `--fix` to eslint helps with a LOOOOOT of the trivial stuff

nodegit locks files on Win32

Thanks for the heads up on this 👍

nodegit locks files on Win32

Shit, I was going to suggest freeing the repo, but it appears you're already doing that.

Let libssh2 configure generate its output

It's allowing him to pipe stdio and stderr from the child process up to the main process.