TM16xx icon indicating copy to clipboard operation
TM16xx copied to clipboard

TM16xxDisplay.cpp bug

Open cNavsky opened this issue 1 year ago • 1 comments

#if(TM16XX_OPT_COMBIDISPLAY) condition reversed in functions: M16xxDisplay::setIntensity (line105), and TM16xxDisplay::clear (line 203).

i.e. it refer to _aModules[I] when TM16XX_OPT_COMBIDISPLAY set to 0

cNavsky avatar Dec 18 '23 19:12 cNavsky

Hi @cNavsky, thank you for your attention to find this bug and for your notification!

Your contribution is much appreciated as I didn't catch this bug. Apparently I didn't notice the incomplete behavior when setting that option to 1 and probably didn't even test setting that option to 0. Duh...

Probably the bug would prevent compilation when the option was set to zero, so I'm happy to fix it. I just committed a quick fix, but don't have time to do a full test now...

For readers: The option is there to reduce the code when using a small MCU.

maxint-rd avatar Dec 19 '23 16:12 maxint-rd