Max Chernyak

Results 52 comments of Max Chernyak

I will proceed after we make [this decision](https://github.com/excon/excon/pull/850#discussion_r1576445426), but absolutely no rush. Just clarifying why I'm not submitting revisions yet.

@geemus Couple of updates. 1. I decided to abandon the idea of showing which steps succeeded in a request timeout, because I'm not sure how to figure that out. 2....

@geemus It's been awhile but I haven't abandoned this. I got connect timeout test to work, but been stuck on simulating a write timeout. This is my latest attempt. ```ruby...

I imagine it's probably because the only way to trigger a write timeout is to somehow make the socket not ready to accept a write, not to delay writing once...

Would love to see this fixed as well. I'm not a python dev, but feels like it might be a tiny fix. 🤔

@soveran (awesome, thanks for chiming in! 🤗) > these two would be equivalent, right? Yes, exactly. (Edited OP for clarity.) > I like option 1, I think it's very straightforward...

@soulcutter thanks for that! I believe the `struct_class` would be a no-op, right? Since there is no type enforcement in this lib, it'd be equivalent to: ```ruby keyword :address #...

@soulcutter No worries, it's definitely a bit weird. All the block does is declare a class named like the attribute, with no further ties to the attribute. I'll take this...

@ikraamg Thanks for the feedback! You're right that it won't break options 1 and 3. However, I wouldn't want to build/support a feature I don't entirely endorse and recommend. If...

Apologies, should've described it better. A separate window is usually ok, but in my case it would be great to open gem code in split view, and have it at...