lambda-perf icon indicating copy to clipboard operation
lambda-perf copied to clipboard

Add Deno

Open tmokmss opened this issue 1 year ago • 9 comments

It appears Deno can sometimes be faster than Node.js or Bun. https://deno.com/blog/aws-lambda-coldstart-benchmarks

It'd be great if this benchmark add Deno runtime.

tmokmss avatar Jul 29 '24 02:07 tmokmss

I agree. I came here looking to see if there was an open request to confirm the claim. Would be great to see this datapoint amongst the other JS runtimes and at varying lambda size - which is something not considered by blog post.

gitblit avatar Aug 06 '24 21:08 gitblit

Having a go at it https://github.com/maxday/lambda-perf/pull/1467

soundstep avatar Sep 06 '24 10:09 soundstep

Hi @maxday (sorry to ping directly), any chance someone can have a look at that one? https://github.com/maxday/lambda-perf/pull/1467 Cheers.

soundstep avatar Sep 10 '24 07:09 soundstep

If helpful for implementing this I just noticed that Deno archived the deno-lambda repo (https://github.com/denoland/deno-lambda) just today, and then point to their official documentation on how to deploy Deno to AWS Lambda here: https://docs.deno.com/runtime/tutorials/aws_lambda/

markhaslam avatar Sep 11 '24 21:09 markhaslam

Cheers, I closed that PR and I'll check what that all means.

soundstep avatar Sep 12 '24 07:09 soundstep

@soundstep Out of curiosity I tried to build a lambda myself following the official docs and was greeted with the error The image manifest or layer media type for the source image... on all combinations of build arch and runtime arch, would love to see how you do it!

EDIT: It's OT, edited in place to reduce noise.

I am using docker BuildKit (formerly buildx) so I have to include --provenance=false to prevent said error during Lambda deployement.

vicary avatar Sep 12 '24 10:09 vicary

Without context, I'm not sure, I don't think I've seen that error; I only built a docker image locally on a MacBook Pro M1, and chose the corresponding arm arch, which worked. I still have an issue that needs sorting but that should be fine.

The easiest is probably to build your image on a github action runner and push it from there?

soundstep avatar Sep 12 '24 13:09 soundstep

FYI, new PR: https://github.com/maxday/lambda-perf/pull/1492

soundstep avatar Sep 16 '24 14:09 soundstep

Thanks a lot! Will take a look at it now

maxday avatar Sep 23 '24 18:09 maxday