Max Blachman

Results 52 comments of Max Blachman

I was working on it around the same time. Really the issue is that I tested it out on my fork that didn't have new changes from master pulled in....

I messed around with this on [a branch in my fork](https://github.com/maxbla/num-bigint/tree/smallvec) of this repo. A naive implementation passed all tests, but was slightly slower for the (rather limited) benches we...

Do you think it would make sense to have all features on by default? Someone who wants to disable a feature probably knows what they're doing (at least more than...

We have some options regarding how to fix this. 1. We could require that types used in a `Ratio` implement `CheckedNeg`. `Ratio::new()` would then return `Option`. I don't like this....

Would it make sense to split up the marker trait from operations involving sign? There could be a trait called `SignOps` or something like that, which contains all methods of...

Off the top of my head, I was just doing some work on formatting traits for `Ratio` in the rust-rational crate. I wanted some way to tell if the numerator...

We could make this not a breaking change by having a `SignOps` trait that has a blanket implementation for `Signed`

Am I wrong to assume that you could have a blanket implementation for `Signed` types and bespoke (non-blanket?) implementations for all the unsigned `Integer`s?

> if I remember correctly there's already some code present that checks if the target process is 64-bit. Yeah, I'm not sure that `is64bit` works as intended. When I tested...

> I'm not sure that is64bit works as intended. Just to get the record straight, the original version of is64bit worked as intended. The reason I thought otherwise is when...