Maximilian Roos

Results 1204 comments of Maximilian Roos

FWIW we've done this in PRQL with `ansi_to_html`: https://github.com/PRQL/prql/blob/ccb25f139bc7e5e990df49549a363c8f89623f59/web/book/src/lib.rs#L180

As a user in the same place as you @xxchan: - I've tried to get rust to serialize yaml nicely, in particular multiline strings — both within and outside of...

Slightly tangential, but we use `description=>` to add context to the errors within a `glob!`: https://github.com/PRQL/prql/blob/c3ab63acdbd0729f73a18aa420216bc91cc7d2d1/crates/prql-compiler/tests/integration/main.rs#L345-L349 (giving more context automatically sounds like a good idea too though...)

Possibly `description` or `debug_expr` could be serialized using the same serializer — and then we could add fields without an additional field? (it would be a small breaking change though,...

This is purely internal, but along with updating the snapshot formats, if we could unify how inline & file snapshots are redacted, that makes some code simpler. https://github.com/mitsuhiko/insta/blob/2959d790fb97882ec65cce639267c4bdfb31dbf2/src/macros.rs#L228-L229 The difference...

I will think more but some initial thoughts: --- Can we replace inline snapshot values without `cargo-insta` already? Assuming the tests execute serially, can we replace the code in the...

> Yes, but not without pulling in the rather complex syn based parsing logic which is a huge dependency. The benefit of a `snap!` macro would be that it could...

The new feature is clever... ...though from someone who is not a maintainer (but a keen advocate and has contributed over the years) — a breaking change seems fairly reasonable....

Totally reasonable! I would love to spend some more time on insta, and I will try and get to this specific thing. (though not in the very short term, so...

FYI I updated this to specific to `allow_duplicates!`, given the discussion in https://github.com/PRQL/prql/pull/3865