Maximilian Roos

Results 1146 comments of Maximilian Roos
trafficstars

Great idea @qorrect ! Any thoughts on which of those we should go with? Chinook seems to have many more stars...

I've tempered my view a little bit on the "single query" point. One issue with putting a single example is that the more recognizable stuff — `from X | filter...

> I think the current example is a little too complicated for someone that is seeing the language for the first time. Great, this is good feedback. Let's simplify it...

Good point @neelance . I think this is how it should work: ```elm derive `from` = 2 ``` but at the moment `from` isn't escaped, because PRQL doesn't know it's...

If anyone wants to take this, it should be a fairly easy change, and would go [here](https://github.com/prql/prql/blob/0.2.5/prql-compiler/src/sql/translator.rs#L817-L837). Otherwise I'll look at this after the current priority issues.

This actually isn't as easy as it seems — @AlexRiedler made a great observation — sometimes we need keywords unquoted. The `as` function is a case of this — with...

I agree with both the question and conclusion — I think we should try and do the minimum possible, and offload everything else to the underlying DB. As you say...

> Let's just leave it here for future generations. Yes, we could put this sort of principle somewhere — i.e. delegate as much to the DB as possible. Maybe we...