Maximilian Roos

Results 1148 comments of Maximilian Roos
trafficstars

I realize there's a lot here and I've been out of this thread for a bit, so please forgive any naive questions! > I would suggest depreciating this behavior in...

Thanks for the thoughtful reply @benbovy (This is a level down and you can make a decision later, so fine if you prefer to push the discussion.) How would we...

(if we do this we should make it kwarg-only)

> My particular use case is that have datasets that are large enough that I can't see the full diff, so might miss major changes. I'm wanting to pass in...

@naught101 to what extent do you think your wants are idiosyncratic vs. better overall? To the extent this is for things that would make the function better for all, then...

As discussed in the dev meeting, this would be great to merge. The test could be to create a small file, and then read it. Would that work @grouny ?

Congrats for doing all these!! This must be (almost?) the last of untyped modules?

One point aside — when this is done, we may be able to turn on mypy's strict mode, at least for the `tests` path, so then tests always need annotations,...

Excellent! Should we hit the green button?

> Usually we do not use `len(input)` or `x in input` though. Maybe reversible container or something else exists? We can build a list if we need a len? Or...