mavo.io
mavo.io copied to clipboard
mavoweb
Suggested edits to data
Hello there! I used Mavo to suggest the following edits: I added sentences to "Function calls" to describe calling js functions Preview my changes here: https://mavo.io/docs/expressions?storage=https%3A%2F%2Fraw.githubusercontent.com%2Fparulsingh23%2Fmavo.io%2Fmaster%2Fdocs%2Fdocs.json&docs-storage=https%3A%2F%2Fgithub.com%2Fmavoweb%2Fmavo.io%2Fdocs%2Fdocs.json
@DmitrySharabin This is not urgent at all, but why can't I preview Parul's changes via the link above? Does it have to do with the PR plugin?
@DmitrySharabin This is not urgent at all, but why can't I preview Parul's changes via the link above? Does it have to do with the PR plugin?
I also noticed that. Will take a look.
Good point @LeaVerou, I updated the docs with the 'Custom Functions' section right after "Function Calls". Let me know if I should make any changes.
Hi there 👋🏻
@LeaVerou, I gave it a closer look and sent two PRs (to mavo and plugins). I also noticed one interesting thing: the docs app on the docs page has both the storage and the source. And because of the source, we can't see the switch to fork dialog. If I'm not mistaken, this line is exactly about that:
https://github.com/mavoweb/mavo/blob/27c4c0b1b74828ac017b6eb4d528e54690776cd9/src/backend.github.js#L199.
Do we need the source in this app?
@LeaVerou you can review this change (updated to include example of adding js function to Mavoscript: Mavoscript.Functions.increment = function(param) {return param+1}).
@DmitrySharabin We don't really need the source, it was just to avoid the API request when loading the data. But it looks like that check needs to change, since it's introducing bugs.
Also, I shouldn't be seeing this dialog when visiting someone else's data:
@DmitrySharabin We don't really need the source, it was just to avoid the API request when loading the data. But it looks like that check needs to change, since it's introducing bugs.
Also, I shouldn't be seeing this dialog when visiting someone else's data:
I'll do my best to fix it.
@LeaVerou I updated the function to be a logical xor custom JS function, so you can look over the changes and let me know, thanks!