qgroundcontrol
qgroundcontrol copied to clipboard
mavlink
QMake patch for Android build in context of using custom subproject.
When building for Android on Windows (using Qt 5.15.2), with a custom sub project present, the QMake in android.pri which sets up a package source directory inside of the build directory failed on multiple points. Notably qmake -install sed -i ... didn't work because sed -i isn't a valid option apparently. That is supposed to search and replace file contents "in place". It is possible however, to use sed -e, which spits out the results over stdout... Further, cmd.exe/batch commands where failing due to the use of forward slashes in paths. I fixed all this, and then confirmed my fix also worked when run on macOS (in the same context).
Is there a particulr reason why this fix is blocked after all checks passed?
Should I request a merge onto a different (dev?) branch perhaps?
If it were faster and easier to contribute here, I'd do so a whole lot more! I work on a closed source version of QGC daily, but am discouraged to share code as a result of the red tape (such this patch never being approved). I assume it's simply very hard for the maintainers to keep up with all the merge requests?
Sorry for taking so long. I was hoping someone else would take over majority of maintenance. That didn't happen. So for now I'm back to doing it myself. Hopefully you'll see better response now.
With regards to this pull, newer versions of OSX have similar but different problems with sed. I"m considering moving this replace scraping stuff to some other mechanism that will work everywhere. Not sure what that is yet. If I don't figure that out I'll use your mods. Stay tuned.
