django-sudo icon indicating copy to clipboard operation
django-sudo copied to clipboard

feat: support django22, py38

Open joshuarli opened this issue 4 years ago • 4 comments

See https://github.com/getsentry/django-sudo/pull/1, which has been tested to work fine on sentry on Django 1.11 with old MIDDLEWARE_CLASSES. Untested on sentry + Django 1.11 + MIDDLEWARE yet (soon though) and sentry + Django 2.0 because still working on that. But, putting this up for some initial review in the meantime.

Happy to make any further tweaks to get these changes merged @mattrobenolt, just for you.

joshuarli avatar Jun 14 '21 20:06 joshuarli

:eyes: I'll take a look at this, but it's likely fine.

mattrobenolt avatar Jun 18 '21 00:06 mattrobenolt

Any updates on this PR?

2tunnels avatar Nov 01 '21 15:11 2tunnels

@2tunnels: I think it's safe to say that when there are updates to this PR, that information will appear here. Matt is likely (and quite understandably) occupied with other priorities and will get to this when he can.

For anyone looking for an alternative that focuses entirely on supported Python + Django versions, you can check out the Elevate project, which should function as a drop-in replacement and supports Python 3.6 – 3.10 and Django 2.2, 3.1, and 3.2.

justinmayer avatar Nov 01 '21 16:11 justinmayer

@justinmayer thank you stepping in.

To explain some context on this project and where I stand personally:

I primarily wrote and supported this for @getsentry. Specifically for @getsentry/sentry.

To put it lightly, Sentry burned me out with how I was treated, and then even vendored this project into their codebase: https://github.com/getsentry/sentry/tree/master/src/sudo

So I personally just have no incentive or personal motivation to contribute to much open source these days after Sentry life. They ruined a lot of my passion and drive.

With that said, I'm happy to transfer this project to @justinmayer since you seem to be just maintaining a fork now. It'd make sense to me add you as a contributor here and give you ownership of the package in PyPI if you'd like.

mattrobenolt avatar Nov 01 '21 18:11 mattrobenolt