Matt Robenolt

Results 178 comments of Matt Robenolt

I'm thinking maybe something a bit more generic for setting any of these: https://github.com/mattrobenolt/jinja2-cli/blob/main/jinja2cli/cli.py#L264-L268 There's quite a lot of options here: https://jinja.palletsprojects.com/en/3.0.x/api/#jinja2.Environment And I think if we're going to get...

Regarding one `Observer` func callback vs some `Observer` struct with callbacks: I think one big benefit of having something like: ```go type Observer struct { ObserveEventResponseMessage(context.Context, connect.Event) ... } ```...

To be explicit, if this is referring specifically to the codes we spit back for the gRPC protocol, and not the connect protocol, I think we should mirror the behavior...

I'd imagine something like this could be entirely implemented as a middleware? Seems likely it could even be an entirely separate library. Obviously this depends on what the actual transport...

Personally, I'm of the opinion all of these things can be done in a third party (or first party) module that is provided through interceptors. Similar to the popular grpc-middleware...

> Though I do wonder what the value of Peer is in its current form. It's really not what you want on the client side (just echoing back the domain...

@jhump you're right, I misspoke about `http.Response`, but my sentiment remains. Using `ConnContext` you can bind the actual `net.Conn` to context, allowing you to derive whatever you want from it,...

Tangentially related, but if you're interested in experimenting with something I've casually been working on: https://github.com/mattrobenolt/ps-http-sim This provides the HTTP shim that you can run locally to pair with a...

This should definitely be done since udp support has been removed from Sentry. :)

It looks like you’re just using it wrong? Unless I’m misunderstanding. `rgb('768310')` isn’t the right input for `rgb()` at all.