jsonld-signatures-bbs
jsonld-signatures-bbs copied to clipboard
`deriveProof` does not support blank node identifiers for` credentialSubject`
Originally discovered by @brianorwhatever
See is reproduction here:
https://github.com/transmute-industries/verifiable-data/pull/76
Surfacing from the linked PR description:
Related issues:
- #121
- #128
Questions:
- Is it possible to use
deriveProofon a credential with nocredentialSubject.id? this example implies that it should be possible...
Current hypothesis is that is may be VC related by not LD Suite related... working to confirm that on the linked PR.
I have attempted to recreate with just the linked data proof from example 12 above and ran into an issue with the id already being a node identifier
removing the id derived a proof properly however I'm now running into a internal error in Neon module: index out of bounds: the len is 5 but the index is 5 problem on verification
Hmm, this test maybe covers this case https://github.com/mattrglobal/jsonld-signatures-bbs/blob/master/tests/AnonymousVC.spec.ts
What's the suggested fix to this issue? Force the use of id in credentialSubject?
@tmarkovski that would be a suggested interim solution however the long term solution is a revision to the proof suite that accounts for this case in the URDNA algorithm. Given the recent consensus we have had around https://github.com/decentralized-identity/bbs-signature/issues/10 I'm working on an updated implementation that incorporates this among various other changes