go-sqlite3 icon indicating copy to clipboard operation
go-sqlite3 copied to clipboard

feature: Allow custom window functions to be registered with the driver

Open ohaibbq opened this issue 1 year ago • 12 comments

This implements the registration of user-defined window functions. It extends the existing RegisterAggregator interface to allow the impl to implement Inverse and Value, in which case, the aggregator can be used both as a regular aggregate function and a window function.

Closes #1215

ohaibbq avatar Feb 11 '24 01:02 ohaibbq

Hi @mattn, how can I help in getting this merged?

ohaibbq avatar Mar 11 '24 02:03 ohaibbq

Sorry my delay. I'll look into it in later.

mattn avatar Mar 15 '24 16:03 mattn

Look good for me. @rittneje any opinion?

mattn avatar Mar 15 '24 16:03 mattn

A friendly bump on this @rittneje

ohaibbq avatar Mar 28 '24 21:03 ohaibbq

@mattn This would be very helpful to get in for the users of https://github.com/goccy/bigquery-emulator I cannot merge my feature branch into the project as it uses a forked go-sqlite3.

Is there anything else I could do to push this along?

ohaibbq avatar Apr 11 '24 01:04 ohaibbq

Yes, I'm thinking this is useful but I want to wait @rittneje 's opinion.

mattn avatar Apr 11 '24 02:04 mattn