mattn
all: format with Go 1.19
Update Go source files to use the '//go:build' lines introduced by Go 1.17 and the doc comment formatting introduced by Go 1.19. This formatting is not changed by Go 1.20.
Note: doc.go and the *userauth* files had to be manually changed in some places to fix indentation.
This does not change how godoc (at least with Go 1.19) renders the package documentation and is backwards compatible (i.e. earlier versions of gofmt will leave this code unchanged - tested with 1.17).
@mattn Please consider merging this. This is blocking further efforts aiming to improve documentation.
Codecov Report
Attention: 3 lines in your changes are missing coverage. Please review.
Comparison is base (
1603038) 46.80% compared to head (af13bcb) 46.59%. Report is 6 commits behind head on master.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@
## master #1130 +/- ##
==========================================
- Coverage 46.80% 46.59% -0.22%
==========================================
Files 12 12
Lines 1534 1526 -8
==========================================
- Hits 718 711 -7
+ Misses 673 672 -1
Partials 143 143
| Files | Coverage Δ | |
|---|---|---|
| sqlite3_go18.go | 77.77% <ø> (-4.58%) |
:arrow_down: |
| sqlite3_load_extension.go | 59.37% <ø> (ø) |
|
| sqlite3_opt_serialize.go | 82.85% <ø> (ø) |
|
| sqlite3_opt_userauth_omit.go | 10.00% <ø> (ø) |
|
| sqlite3.go | 52.64% <50.00%> (ø) |
|
| callback.go | 58.53% <33.33%> (ø) |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@mattn We definitely need this change merged before submitting further documentation improvements!
Closing since https://github.com/mattn/go-sqlite3/pull/1208 took care of this.