Inconsistency between check_failed and did_error

[bcomnes]

Is there a reason that when a ok check fails that it is handled with check_failed instead of did_error? They seem to serve a similar function.

[mattly]

from what I can remember and what I can read, check_failed was created for the check type (which is basically a way of hooking arbitrary expressions into the ok system) and is only updated on status operations, which are performed during satisfy as well. did_error is meant to be used alongside did_install, did_upgrade, did_update and the like to determine if the satisfy (install | upgrade) operation failed. This could probably be better documented.

[bcomnes]

👍 Feel free to close unless you want to keep the reminder to documnet. I've lost too much context to come up with a quick fix on this atm.