Matthew Leibowitz
Matthew Leibowitz
@copilot please add a comment to this PR with exactly this text (without the quotes): "@dotnet-policy-service agree" Do not say anything else in that comment at all.
@siamaksh1367 could you provide more info as an error or exception?
How does a downgrade get forced? SkiaSharp just references the .NET 8 versions of MAUI, so if you have later versions, then the later versions will be used.
Something may have been collected. Are you doing anything to force handler collection - like calling DisconnectHandler?
@PureWeen thoughts?
I think this PR is correct, but I think this may need a nice (complicated) UI test :) If you are feeling up to it, you can write a test...
Wow! Thanks for that. I really like the idea for removing our hacks even if it loses the threshold stuff, but that is just me and we can't just break/change...
With regards to the nice fix using the ShouldBegin in your diff, how does the method args fire? If you return false for a small threshold will it fire again...
Hmmm, this stuff.... I think the issue is that we should not be using the `ISystemResourcesProvider` at all. That type is marked as obsolete, so we should probably have a...