Matt Johnson-Pint
Matt Johnson-Pint
Given that Microsoft recently ended support for .NET Framework 4.6.1 on April 26, 2022, I would be ok bumping that to 4.6.2 at the same time we add a `net7.0`...
https://develop.sentry.dev/sdk/sessions/#filter-order
@vlaterz - We think this might be a bug. We're looking into it and will get back to you. Thanks!
@vlaterz - can you please see if you can recreate this on sentry.io?
I've figured this out, and since it's not related specifically to Serilog, I've opened a new issue. Please follow #1956 for updates. Closing this one. Thanks.
> Does scope.Platform qualify? #1590 Yes, I think so.
Another - `Contexts` didn't need to inherit from `ConcurrentDictionary`. It would be better to inherit from `IDictionary` instead, and encapsulate it instead. See comments : https://github.com/getsentry/sentry-dotnet/issues/1332#issuecomment-1251080640
Interesting. And thanks for the PR! I think you are probably correct, but would you please elaborate on the use case? What problem does it solve for you? Thanks.
Also, a unit test would be super helpful.
Looking over this closer, it seems that this change would make both branches of this function do the same thing. ```csharp private static ISpan? GetParent(SentryEFSpanType type, Scope scope) { if...