Matt Johnson-Pint

Results 434 comments of Matt Johnson-Pint
trafficstars

During initialization, event processors can be added to the options: ```csharp .UseSentry(options => { options.AddEventProcessor(new MyEventProcessor()); } ``` They can also be added for a given scope: ```csharp SentrySdk.ConfigureScope(scope =>...

Looking over the PR, the main issue I see is now *all* processors are registered on the scope. Instead, let's control this based on how the processor was registered with...

Actually, ignore my last comments. There's no need to separate those paths out, as the effect would be the same as the approach you're currently taking. In other words, registering...

I see we are doing this for event processors and exception processors. Please also do the same for transaction processors added in #1862. Looks like we missed this back then....

@SimonCropp > wouldn't this result in: processors explicitly added to options being ignored? No, because `scope.GetAllEventProcessors()` returns both: https://github.com/getsentry/sentry-dotnet/blob/77ccdb2dc01b85c1dc53604f9186f715f66b9ff8/src/Sentry/ScopeExtensions.cs#L18-L33

Needs transaction processors added, and a changelog entry, then LGTM. Thanks!

I added the changelog entry. We'll do transaction processors in a separate PR. Thanks for your contribution!

Actually, I need to do more testing before this can be released. We have lots of other places where we have iOS-specific code blocks that assume the Sentry Cocoa SDK...

RE: > if missing return null (i am surprised this is valid?) Not all envelopes contain "events". In particular, a [session update](https://develop.sentry.dev/sdk/sessions/#session-update-payload) will not have an `event_id` of its own....