Matt Johnson-Pint

Results 428 comments of Matt Johnson-Pint
trafficstars

Looks like NLog 5 was recently released and has lots of breaking changes. https://nlog-project.org/2022/05/16/nlog-5-0-finally-ready.html First item says: "Strong Version Changed" - so I don't believe a binding redirect is possible....

Actually, I take that back. It looks like they just mean that they changed the major, not the public key token - and they advise binding redirects on that announcement...

I agree, however that will be a breaking change, so we can do that in the next major release. I'll mark this as an enhancement to the 4.0.0 milestone. @mrfatmen...

Glad to hear the binding redirect works. We'll keep this issue open though so that we remember to update NLog in a future release. Thanks.

Going to disable it on Windows for now. Leaving this issue open though, so we can remember to turn it back on when GitHub fixes the underlying issue.

I think I'd rather implement a new interface, `ISentryTransactionProcessor`. The other approach mentioned would require all event processors to also process transactions, which shouldn't be necessary in all cases, IMHO.

@bruno-garcia - Should there also be a `BeforeSendTransaction` option?

Also, it would appear transactions don't participate in a scope. Should they? (Event Processors and Exception Processors can both be set on a scope.)