Matthieu Rolland

Results 52 comments of Matthieu Rolland
trafficstars

@khouloudbelguith your feedbacks have been addressed: 1. fixed 2. not reproduced, as seen with you 3. not reproduced, as seen with you 4. fixed 5. fixed 6. fixed 7. fixed...

@FabienPapet I added a commit with some wording modification About the regex: did you test it in the form ? I tried your PR and it seems like I can...

Hello @khouloudbelguith I updated the pull request, now you will have this message if you don't give a correct version number

thank you @khouloudbelguith I fixed your first issue :+1: About the second one: - I can't reproduce it following your steps, I guess something else went wrong in your case...

shall we wait for the merge of pr #27927 on develop before merging this one ?

I reproduced the bug, but with autoupgrade on master branch, not dev :+1: ![image](https://user-images.githubusercontent.com/1784781/191792123-7692851a-66b7-44ee-8546-282392947b11.png)

Looks like your PR breaks unit tests in `tests/Unit/Core/Theme/ConfigReaderTest.php`

- Choose the zip for the 8.0.0 - Put 1.7.8.7 as a version - Choose the XML file for the 8.0.0 It's because the given version number is not correct,...

I think the trigger_error should be a trigger_deprecated...

## State of the 5.0 milestone and the 5.x branch 1/ About the 5.0 milestone, after investigating the PRs on the 5.O milestone, I didn't find any relevant BC break,...