matthieu-m

@bjorn3 > This project function can't be made to have a safe interface as anyone could write their own function returning a null pointer. Having a safe way to do...

> I am not familiar with the French layout, but according to the wikipedia page you linked the situation seems to be very similar there. You are correct, it's already...

@deltragon > I am not familiar with the French layout, but according to the wikipedia page you linked the situation seems to be very similar there. Further investigation led me...

> Of particular note might now be the [`generativity`](https://docs.rs/generativity/latest/generativity/) crate, which neatly abstracts creation of a brand into a _macro_ such that it no longer requires closures / scopes. First...

@Amanieu Would it be possible to benchmark on SSE2? I'd like to see if it's worth it before trying to make the generic and neon targets pass (especially the generics...

One thing I wonder, is how many collisions there are in the first place. Perfect hashes should be akin to uniformly spread values across the 0-127 range today. Given the...

> @matthieu-m It seems to me that you did not take into account that on the x64 platform the expression `let top8 = hash >> (MIN_HASH_LEN * 8 - 7)`...

@JustForFun88 You seem to have many (good!) suggestions, and unfortunately I don't have much bandwidth right now. I can probably get to them eventually (I may have some time in...

> > This switches from the top 8 to the bottom 8 bits, and will overlap with `h1`. Is there a reason to prefer to the bottom 8 (and adjust...

I don't think it makes much sense either. Making a PR was the easiest to share both code and result, but it may be a bit too specific.