symfony-service-definition-validator icon indicating copy to clipboard operation
symfony-service-definition-validator copied to clipboard

Support for newer dependency versions like symfony/dependency-injection

Open carlos-mg89 opened this issue 4 years ago • 3 comments

Hi!

Are there any plans to upgrade the symfony/dependency-injection dependency to a newer version, like 4.0 ?

I'm finding troubles specially with this dependency. If you don't have any plans (which is totally acceptable) to do so, would you be keen to accept a PR where I work to upgrade the symfony/dependency-injection dependency to 4.0 or even newer along with the required changes in the code?

Thanks in advance :)

carlos-mg89 avatar Mar 19 '21 09:03 carlos-mg89

Hi, thanks for bringing it up. I have given up on this tool because I'm using auto-wiring now, which will give me the same kind of warnings as this library does. Would you consider taking over this project?

matthiasnoback avatar Mar 19 '21 10:03 matthiasnoback

Hi @matthiasnoback , that was a savvy decision. As soon as we're able to enable auto-wiring in all our projects, that's our goal as well.

Right now I wouldn't like to go as far as taking over the project. I don't know how how long I'd be working on the project that depends on this dependency. However, I'm very keen to invest time and try to bump the symfony/dependency-injection to a higher package version.

If you are OK accepting PRs, for the moment, that would be more than enough. I wouldn't dare to go further than that, since I'm dubious we will need it for that long time.

Let me know your thoughts, since I'm happy to discuss it further :)

carlos-mg89 avatar Mar 22 '21 08:03 carlos-mg89

Thanks for considering it! Yes, that's okay. Good luck :)

matthiasnoback avatar Mar 22 '21 15:03 matthiasnoback