matthewei

Results 57 comments of matthewei

> @matthewei: Cannot trigger testing until a trusted user reviews the PR and leaves an `/ok-to-test` message. @xpivarc There are some errors for this PR and I have no access...

> @matthewei Failure logs are found [here](https://storage.googleapis.com/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/10834/pull-kubevirt-check-tests-for-flakes/1745799290531352576/artifacts/k8s-reporter/pods/1_kubevirt_virt-controller-75ff7c575f-scmlf-virt-controller.log) Thanks a lot @alaypatel07 , I feel like it has nothing to do with this PR? I want to debug it further

> Thanks @matthewei! I still see the first commit that should be dropped from this PR! Also, we need to cover this new feature with a unit test. Feel free...

> Thanks @matthewei! I still see the first commit that should be dropped from this PR! Also, we need to cover this new feature with a unit test. Feel free...

> /hold The PR looks good, but a unit test is required to get this merged. Also, the first commit should be dropped, because it is not adding anything. Last...

> > Hi, sorry for that. I have dropped the first commit. I have added the E2E test for this PR. Could you check it again? > > No problem...

I think it't better to set hostname rather than virt-launcher. WDYT?

> I fail to understand what is the bug is here. > > > If we use virt-controller to generate it and we can update the vm's configuration > >...

I think you should set `terminationGracePeriodSeconds`