Matt Hargett

Results 79 comments of Matt Hargett

Just a heads up that I'm going to be on vacation for 2 weeks. I'll put this PR in draft until I'm back, then fold in the feedback. Thanks!!

Just a few more cleanups, from my perspective, but let me know if there's additional feedback!

@adangel I'm not sure the build timeout that causes CI to fail is relate to my changes, but I can't re-run the job. Can you review and debug from your...

@adangel I finally won the dice roll with the maven server being overloaded. Would it be possible for this PR to be included in 6.50 release?

> Note: I'm also fixing are parsing issue around comments, mentioned here ([antlr/grammars-v4@ff6ef1e#r84475967](https://github.com/antlr/grammars-v4/commit/ff6ef1e876060e9e66535e88879e1ccd045647e4#r84475967)). Keep this in mind when updating the grammar back in https://github.com/antlr/grammars-v4/tree/master/lua Thanks! I saw that person's comment...

ping on this? flow is failing for all the teams I work with that use react-apollo.

A few hours later, the computer goes to sleep. When it wakes back up, I have my 5120x1440 native resolution, but BetterDisplay doesn't think any monitor is connected. ![image](https://user-images.githubusercontent.com/1550766/180580949-0aedb8da-72c5-4d66-a384-5aad7af0b6bd.jpeg)

> Hi @matthargett - do you experience similar issues with a direct connection? There are only USB-C ports on this MacBook, no HDMI or DP out. I do have a...

I didn't see the text for enabling logging, maybe you didn't paste? Screenshots of it only really giving me 3840x1080: Note that if I push the BD slider to 5120x1440,...

@sebmarkbage it looks like some simple lint fixes will make this go green: ``` /home/circleci/project/src/intrinsics/dom/document.js 16:8 error 'invariant' is defined but never used no-unused-vars /home/circleci/project/src/intrinsics/ecma262/JSON.js 28:10 error 'ValuesDomain' is defined...