pwned-passwords icon indicating copy to clipboard operation
pwned-passwords copied to clipboard

Published 20 hours ago • verified publisher icon mattevans

Add count of compromises

Open NickBorgers opened this issue 3 years ago • 2 comments

This MR would resolve https://github.com/mattevans/pwned-passwords/issues/4 by adding a new method func (c *Client) CompromisedCount(value string) (bool, int64, error). I turned func (c *Client) Compromised(value string) (bool, error) into a wrapper that simply doesn't return the int count. This maintains the API contract while minimizing extra lines of code.

I also containerized testing by adding a Makefile and Dockerfile, but those have no effect on functionality. I've been running make test repeatedly to validate changes; make build once to build the base image.

NickBorgers avatar Jul 30 '22 21:07 NickBorgers

@NickBorgers Hey! Thanks for this. I'll set aside some time this weekend to review and get it merged. Appreciate it. 🥇

mattevans avatar Aug 02 '22 22:08 mattevans

@NickBorgers Hey! Thanks for this. I'll set aside some time this weekend to review and get it merged. Appreciate it. 🥇

Bumping this. I don't understand what happened with the Travis CI job; I'm not sure my changes caused it.

NickBorgers avatar Sep 20 '22 01:09 NickBorgers