mattermost-plugin-github icon indicating copy to clipboard operation
mattermost-plugin-github copied to clipboard

Support for both github.com and enterprise server

Open rien opened this issue 7 years ago • 6 comments

It is currently impossible to integrate two GitHub servers with the same plugin.

As a workaround: will stuff break if I edit the .tar.gz to just change plugin id?

rien avatar Oct 19 '18 13:10 rien

@rien, with respect to the plugin id: if you change it everywhere you find it, it should "just work". Note that it's present in the plugin.json, as well as the server and webapp code.

Alternatively, if you rebuild the plugin from source you can just edit plugin.json and the framework should take care of effecting all the necessary changes.

(Leaving the issue open because of the larger request for supporting multiple servers.)

lieut-data avatar Oct 19 '18 14:10 lieut-data

Is it okay if I give this a try?

sandeepsukhani avatar Feb 23 '19 16:02 sandeepsukhani

@sandlis Definitely, that would be great!

jasonblais avatar Feb 23 '19 16:02 jasonblais

@jasonblais Initiated a conversation here for design discussion.

sandeepsukhani avatar Feb 25 '19 08:02 sandeepsukhani