docs icon indicating copy to clipboard operation
docs copied to clipboard

Calls: Add full support for config environment overrides

Open streamer45 opened this issue 6 months ago • 7 comments
trafficstars

Summary

With https://github.com/mattermost/mattermost-plugin-calls/pull/1004 in, we can finally update our docs to include full coverage of environment overrides for Calls plugin config settings.

Ticket Link

https://mattermost.atlassian.net/browse/MM-62732

streamer45 avatar May 15 '25 16:05 streamer45

Newest code from mattermost has been published to preview environment for Git SHA 515c8b087cfc9bc7bf4dc68f833a88edcf53b96b

github-actions[bot] avatar May 15 '25 16:05 github-actions[bot]

Newest code from mattermost has been published to preview environment for Git SHA 515c8b087cfc9bc7bf4dc68f833a88edcf53b96b

github-actions[bot] avatar May 15 '25 16:05 github-actions[bot]

Thanks, @streamer45!

#radar: I noticed that the env vars for Calls diverge a bit from other env vars across the platform. The formula used takes the config.json setting, adds MM_ to the beginning, converts all characters to uppercase, and replaces the . with _. The config name itself becomes all one word with no underlines between words.

Given the established pattern, I wonder if this new pattern may result in calls env vars being slightly less guessable/discoverable.

The concern is valid, but I made that choice because I find the new pattern superior in readability and far easier to debug as a consequence. I personally can't work well with something like MM_SERVICESETTINGS_TLSSTRICTTRANSPORTMAXAGE (an example to make the point).

streamer45 avatar May 16 '25 07:05 streamer45

That's an excellent point, @streamer45! Thank you for the context! What release is this docs update tied to? v10.9?

cwarnermm avatar May 16 '25 12:05 cwarnermm

Newest code from mattermost has been published to preview environment for Git SHA 4870f0fdbfe5eec65191d9250b83edaeeceee995

github-actions[bot] avatar May 16 '25 12:05 github-actions[bot]

That's an excellent point, @streamer45! Thank you for the context! What release is this docs update tied to? v10.9?

Yes @cwarnermm , that's where Calls v1.8.0 (which introduces these changes) will be pre-packaged to.

streamer45 avatar May 16 '25 12:05 streamer45

Newest code from mattermost has been published to preview environment for Git SHA 564ea7086154ac0168e5a55a32c293f709d9c8dc

github-actions[bot] avatar Jun 13 '25 21:06 github-actions[bot]

Newest code from mattermost has been published to preview environment for Git SHA ed6c544cf48655d5602abad5d9ea0aa1d3862a83

github-actions[bot] avatar Jun 16 '25 05:06 github-actions[bot]