mattdurham
mattdurham
@jamesalbert should have a branch with some changes for V2 tomorrow for you to take a look at
By tomorrow I mean today, ended up making some significant changes. Porting the changes into a v2 integration now
@jamesalbert created a branch https://github.com/grafana/agent/tree/ssl_exporter with my changes, its a bit rough and I want to cleanup, see what we can share between v1/v2 but please give a look.
There are differences due to how v2/v1 work, that being said we can probably simplify it. I can take a spin at it tomorrow morning and see what I can...
100% in favor of both 1 and 2. Having consistency between the various subsystems is a win even if not entirely in line with those subsystems original intent.
Absolutely go for it. The snmp_exporter would be the best place to start, we are switching to a new way of handling exporters and if I was in your shoes...
Looks like there are some linting errors and issues building on linux. `make lint` will show the linting, and the errors look to be entirely around needing `build tags or...
Going to give this a bit of thought. I hesitant to set successful running until we have loaded the configuration. Though the worst-case scenario is it comes up and then...
I am more concerned with the behavior of the datatypes than the actual implementation. I agree that I haven't pointed out explicitly where the current behavior deviates from the prometheus...
Discussion around this topic leads towards removing the FlowMetric concept and replacing it with stock prometheus, but transforming the metrics.receiver into an appendable/appender interface. Noting the non-obvious change of returning...