Matt Cary

Results 164 comments of Matt Cary
trafficstars

Is this necessary? Especially since the intree cloud provider is changing, it might be nicer if we allow ourselves to figure out the best way to report k8s vs CSI...

/lifecycle frozen /remove-lifecycle stale On Wed, Dec 23, 2020 at 10:51 AM fejta-bot wrote: > Issues go stale after 90d of inactivity. > Mark the issue as fresh with /remove-lifecycle...

I dunno, creating a mock that would actually catch errors or regressions is very hard. Maybe just stick with fakeexec for now and we'll see how it does. This should...

Thanks for laying out the state of things so clearly! Would it be easy to add a gcp-persistent-disk-csi-driver/test/e2e test? (confusingly this is not the k/k e2e test) It should be...

> @mattcary, while it would be possible to add a new test to test/e2e, it's not easy to fix e2e/sanity - all `NodeStage` calls there will fail, because the fake...

See #991 and https://github.com/kubernetes/test-infra/pull/26354, we're making the sanity tests optional while we sort this out. I think that unblocks this PR? (as soon as the test-infra change goes in)

@mauriciopoppe and @jingxu97 for the windows questions. /cc @mauriciopoppe /cc @jingxu97