Matt Donoughe

Results 70 comments of Matt Donoughe

Yeah I think this is the right thing to do, even if the `%` was supposed to be escaped.

I'm not a maintainer on this project so my approval doesn't mean anything.

This is still reproducible with the given example.

Are you sure? That is not the behavior I get on the master branch (commit aa6d185251e3ec4e6fbc80489374c5fede9ccca1). ``` > PackageURL.fromString('pkg://maven/org.apache.commons/io') PackageURL { type: 'maven', name: 'io', namespace: null, version: null, qualifiers:...

You may want to hold off on this PR pending the outcome of package-url/purl-spec#300. I think this way makes sense, but there are arguments to be made for doing it...

Is there a difference between pkg:deno and pkg:esmsh? Deno can potentially load from any host, and none of the host names here are valid PURL package types. In the documentation,...

Is esm.sh any different in terms of usage? It seems like the dependencies are expressed and resolved and used the same as far as the runtime is concerned. It has...

Creating more types seems like it just creates more types. What is the value of `pkg:esmsh` `pkg:skypack` `pkg:deno` `pkg:jsr` `pkg:unpkg` `pkg:cdnjs` `pkg:jsdelivr`?

Isn't it basically the same as Go? Go packages can be hosted on different services but hosting on GitHub or GitLab or cs.opensource.google doesn't change the package type.

[NPM can host typescript code just fine](https://www.npmjs.com/package/@types/node). NPM doesn't care if the package is runnable at all. I've seen NPM packages that contain only video files. The difference between "deno"...