Matt Oakes

Results 92 comments of Matt Oakes
trafficstars

@phil-flyclops I have it set to whatever is the default for the latest version of React Native. I'll take a look into this in more detail soon.

Ok. It seems like I'll need to take a look at this.

To fix this: 1. Ensure you are calling this inside a script script that runs in `setupFilesAfterEnv` NOT `setupFiles` 2. Change the import in the script to `const { expect...

I realised that just after I made this. I've opened a PR over there including both parts https://github.com/react-native-community/react-native-camera/pull/2050

This is defiantly a good idea, however, I think we should still allow developers to use the current `android.location` API if they want as there are some good reasons to...

I have implemented it in `react-native-location` by having an [abstract interface which each provider can implement](https://github.com/timfpark/react-native-location/blob/163ea5186183e668dc6c480054b947e17cb7a6b8/android/src/main/java/com/github/reactnativecommunity/location/RNLocationProvider.java) and then implementing it for each provider: * [`android.location`](https://github.com/timfpark/react-native-location/blob/163ea5186183e668dc6c480054b947e17cb7a6b8/android/src/main/java/com/github/reactnativecommunity/location/RNStandardLocationProvider.java) * [Google Play Services](https://github.com/timfpark/react-native-location/blob/163ea5186183e668dc6c480054b947e17cb7a6b8/android/src/main/java/com/github/reactnativecommunity/location/RNPlayServicesLocationProvider.java) There...

@tijs It is, and that's why this library should support it, however, as [noted above](https://github.com/react-native-community/react-native-geolocation/issues/6#issuecomment-479089621) it's not always available on all devices so we need to support both.

Exactly. We need to discuss how this will work exactly, but I think that we will try to use the best API possible by default and let the developer override...

I think the default should be `"auto"`. It should try to use the Google Play one, but if one of these conditions is not met, it would automatically fallback to...

@nicklockwood No, there are no updates. Contributions are always welcome though.