matrix-react-sdk
matrix-react-sdk copied to clipboard
Add persistence of collapsed state of space panel
Signed-off-by: gefgu [email protected]
Checklist
- [x] Tests written for new code (and old code if feasible)
- [X] Linter and other CI checks pass
- [X] Sign-off given on the changes (see CONTRIBUTING.md)
Notes: Add persistence of collapsed state of space panel. It fixes vector-im/element-web#23172
Type: enhancement
Behavior: (Hard reload was made by ctrl + shift + r)
https://user-images.githubusercontent.com/53129852/188504813-b9f60b83-52fa-484c-ae26-2d864db1813b.mp4
This change was made using LocalStorage implemented inside of the component. I'm not sure it's the best solution because of most of the other LocalStorage values are implemented using stores. In this way, I want feedback about my approach and I'm willing to keep working on this issue until it is resolved.
Here's what your changelog entry will look like:
✨ Features
- Add persistence of collapsed state of space panel. It fixes vector-im/element-web#23172 (#9245). Contributed by @gefgu.
I've added the cypress test and would be delighted if you could review it - It is the first time I work with cypress :). Also, I've removed the try/catch block. It does not seems to be necessary.